comment on

and probably a tiny bit faster

Yep, you've got me there, and then some:

           Rate      OP   other  fishbot   Joost
OP        293/s      --    -21%     -76%    -92%
other     369/s     26%      --     -69%    -90%
fishbot  1205/s    312%    226%       --    -68%
Joost    3723/s   1173%    908%     209%      --
[download]

"other" was a solution using values with a regex. "OP" was a corrected key and regex version of the OP's code.

Update: Added OP-style solution to benchmark.

Benchmark code used:

use strict;
use warnings;

use Benchmark qw{ cmpthese };

our %a;
$a{ $_ } = "foo" for 1..1000;
$a{ 1 + int rand 1000 } = '' for 1..10;

cmpthese( -3,
   {
      Joost    => 'scalar grep { $_ ne "" } values %a',
      fishbot  => 'scalar grep { $a{$_} ne "" } keys %a',
      other    => 'scalar grep { ! /^$/ } values %a',
      OP       => 'scalar grep { $a{$_} !~ /^$/ } keys %a',
   }
);
[download]

In reply to Re^3: Count non-empty hash values by fishbot_v2
in thread Count non-empty hash values by pboin

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


P is for Practical
	PerlMonks